Allow empty specifier in constraints #8209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
the
skip news
|
Oh wait, I’m checking |
|
Err, the nameless constraint case is much more difficult to deal with. I’ve opened #8210 to discuss this further, but this one can probably go in first. |
|
This got covered in my constraint fixup PR, so I don't think it's needed any more. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test
test_constrained_to_url_install_same_urlis currently failing because it supplies a constraint with an empty specifier, which evaluates to false, failing the assertion. (A constraint with an empty specifier won’t actually do anything, so why is this allowed…? But apparently it is allowed.)InstallRequirement’s type hints sayreq.specifieris alwaysSpecifierSet, i.e. the assertion is not needed, so I simply dropped it.