Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer Azure Pipelines setup #8028

Merged
merged 2 commits into from
Apr 12, 2020
Merged

Conversation

pradyunsg
Copy link
Member

No one would mind slightly better naming; I'm sure. :)

@pradyunsg pradyunsg added skip news Does not need a NEWS file entry (eg: trivial changes) C: automation Automated checks, CI etc labels Apr 12, 2020
This wasn't actually ever used, since the value was always '$(useVenv)'.
@uranusjr
Copy link
Member

uranusjr commented Apr 12, 2020

This seems to catch an edge case in the auth-dedaction logic. A good thing, I guess? :p

Failure log: https://dev.azure.com/pypa/pip/_build/results?buildId=21943&view=logs&j=d5516b16-d635-5f23-ed1f-618b454a3b40&t=4b6551ce-09cf-548f-8bd5-83779dcb7360&l=65

@pradyunsg
Copy link
Member Author

@pradyunsg
Copy link
Member Author

pradyunsg commented Apr 12, 2020

I like the names a lot and I'm reckless enough to merge this without any green ticks. :P

@pradyunsg pradyunsg merged commit 745e21f into pypa:master Apr 12, 2020
@pradyunsg pradyunsg deleted the ci/better-names branch April 12, 2020 23:17
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: automation Automated checks, CI etc skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants