Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use names in AUTHORS.txt #7899

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

deveshks
Copy link
Contributor

@deveshks deveshks commented Mar 25, 2020

Fixes and closes #5979

The git command to list all authors at time of release was update to only include names, and that list was used to update AUTHORS.txt

@uranusjr
Copy link
Member

You’ll need to reformat the Git commit message to make it render correctly. Namely, the message title should be within 50 characters. Here’s a general guide on how to format the message.

@deveshks deveshks force-pushed the remove-emails-from-authors branch from e9ed3da to 30d1870 Compare March 25, 2020 17:59
@deveshks deveshks changed the title Remove emails from AUTHORS.txt to prevent usage for spamming, and onl… Only use names in AUTHORS.txt Mar 25, 2020
@deveshks
Copy link
Contributor Author

Thanks @uranusjr , I have updated the commit message

@uranusjr
Copy link
Member

Thanks! I have no more comments, and will pass this to @pradyunsg for the actual review.

@uranusjr uranusjr requested a review from pradyunsg March 25, 2020 18:31
@deveshks deveshks closed this Mar 25, 2020
@deveshks deveshks reopened this Mar 25, 2020
@deveshks
Copy link
Contributor Author

Thanks @uranusjr , I will wait for @pradyunsg .

I am also observing that a lot of the pull requests are getting stuck at continuous-integration/travis-ci check, like this one did, but when I close and reopen the PR, this gets changed to continuous-integration/travis-ci/pr and the check passes

@deveshks deveshks closed this Mar 25, 2020
@deveshks deveshks reopened this Mar 25, 2020
AUTHORS.txt Show resolved Hide resolved
AUTHORS.txt Show resolved Hide resolved
@deveshks
Copy link
Contributor Author

Thanks @pradyunsg for the review. Please feel free to merge the PR, I see that all checks have passed.

@pradyunsg pradyunsg merged commit eb232dc into pypa:master Mar 27, 2020
@pradyunsg
Copy link
Member

Thanks @deveshks!

@deveshks deveshks deleted the remove-emails-from-authors branch March 27, 2020 11:25
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove emails from AUTHORS.txt
3 participants