-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Version Mismatch Alert #7800
Conversation
@uranusjr @pradyunsg The checks are completed and passing on the Azure pipeline but don't seem to have propagated to GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the message has some room for improvement; the current wording could be confusing to less experienced users. Python version mismatch… to what?
I have Python version 3.5 (for example), there’s nothing wrong with it?? (simulated response)
"Link requires a different Python (3.6.5 not in: '== 3.6.4'): " | ||
False, 'INFO', | ||
"Package does not meet the Python version requirement. " | ||
"Required version '== 3.6.4', Current version 3.6.5 " | ||
"https://example.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The final link part looks weird to me, but I don’t have a good suggestion either 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is utilized for testing as I see here
Lines 80 to 82 in 4775afb
expected_return, expected_level, expected_message = expected | |
link = Link('https://example.com', requires_python='== 3.6.4') | |
caplog.set_level(logging.DEBUG) |
The news fragment should be named |
Updated, Should close #7797. @pfmoore @pradyunsg @chrahunt |
Hi @anuditnagar You should probably revisit the approach in this PR. As per #7797 (comment) , changing the message to I just tried this on
|
Closing due to lack of movement here. Please feel free to file a new PR if you want to get the ball rolling again! :) |
Prototype Implementation for #7797