Refactor yanked warning out of package finder #7796
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this when reading @pfmoore’s effort to wire pip internals to ResolveLib primitives.
The previous implementation assumes that when a best candidate is found, it will be downloaded/installed. This will no longer be the case for the new resolver, since it may decide to discard the candidate after inspection and fetch a new one.
By moving it to
InstallRequirement.populate_link()
, we can be sure that the warning is only set when the yanked link is actually populated for installation.