Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when pip is not building a wheel due to lack of wheel package #7768

Merged
merged 5 commits into from
Feb 23, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/461bbf24-25f6-488a-b7c0-7ff34bf4f0c1.trivial
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add logger alert for when 'wheel' is not installed.
anudit marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 4 additions & 0 deletions src/pip/_internal/wheel_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ def _should_build(

if not req.use_pep517 and not is_wheel_installed():
# we don't build legacy requirements if wheel is not installed
logger.info(
"Could not build wheels for %s,"
"since package 'wheel' is not installed.", req.name,
)
return False

if req.editable or not req.source_dir:
Expand Down