Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve String Formatting Compatibility #7762

Merged
merged 4 commits into from
Feb 21, 2020
Merged

Improve String Formatting Compatibility #7762

merged 4 commits into from
Feb 21, 2020

Conversation

anudit
Copy link
Contributor

@anudit anudit commented Feb 21, 2020

Update existing printf-style string formatting to a ''.format() style to improve compatibility.

@anudit anudit marked this pull request as ready for review February 21, 2020 05:44
@anudit anudit requested review from pradyunsg and chrahunt February 21, 2020 05:46
@pradyunsg pradyunsg removed the request for review from chrahunt February 21, 2020 06:34
pradyunsg
pradyunsg reviewed Feb 21, 2020
View reviewed changes
AUTHORS.txt Outdated Show resolved Hide resolved
uranusjr
uranusjr reviewed Feb 21, 2020
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (aside from the AUTHORS issue mentioned above)

@anudit anudit requested a review from uranusjr February 21, 2020 12:14
@pradyunsg pradyunsg merged commit 082c0f0 into pypa:master Feb 21, 2020
@pradyunsg pradyunsg removed the request for review from uranusjr February 21, 2020 16:18
@pradyunsg
Copy link
Member

Thanks the PR @anuditnagar! ^>^

Would like like to work on another issue in pip? If yes, lemme know if you want a suggestion for an issue to work on. :)

@anudit
Copy link
Contributor Author

anudit commented Feb 22, 2020

I'd love to work on any open issues.

@pradyunsg
Copy link
Member

@anuditnagar #7709

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Mar 27, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@uranusjr uranusjr uranusjr left review comments

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anudit @pradyunsg @uranusjr