Explicitly set newline when rewriting for release #7600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
approved these changes
Jan 15, 2020
xavfernandez
approved these changes
Jan 15, 2020
xavfernandez
added
skip news
|
note: merge conflicts! |
|
Note: this was squash merged, to avoid adding another quirk to git graph -- it's bad enough already. :) |
|
As always, thanks @uranusjr for trying this out and for filing the PR! ^>^ |
deepak1725
pushed a commit
to deepak1725/pip
that referenced
this pull request
Jan 20, 2020
Merged
pradyunsg
added a commit
that referenced
this pull request
Jan 23, 2020
This reverts commit c55eee4.
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the newline to always be
\n. This is probably fine because we are committing the files immediately anyway, and Git would perform the necessary normalisation on checkout for people runningcore.autocrlfwithtrueorinput.