Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move final wheel builder copy operation to wheel command #7517

Merged
merged 5 commits into from
Dec 29, 2019

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Dec 26, 2019

Removes one more non-build concern from WheelBuilder.build().

@chrahunt chrahunt added skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code labels Dec 26, 2019
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this changes the behavior so that wheels will appear after all builds instead of as they are built, however:

  1. I think that this will be necessary going forward anyway with the new resolver work, since we won't know until the end which wheels are relevant, and will have to build some wheels in the middle of resolving
  2. the wheels that we do succeed in building will be available in the cache, so if an issue does happen the next invocation of the command should be fast since it will take files directly from the cache instead of rebuilding them

So LGTM

@sbidoul sbidoul marked this pull request as ready for review December 26, 2019 22:08
@pradyunsg pradyunsg removed the skip news Does not need a NEWS file entry (eg: trivial changes) label Dec 28, 2019
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though this should be called out in the release notes.

@sbidoul sbidoul force-pushed the wheel-builder-disentangle-6-sbi branch from 1ef342d to 1f39950 Compare December 28, 2019 15:18
@sbidoul
Copy link
Member Author

sbidoul commented Dec 28, 2019

I added a .feature news explaining the new behavior. I suppose it's not a significant change that needs to be called out as breaking.

@chrahunt chrahunt merged commit 711cf4d into pypa:master Dec 29, 2019
@sbidoul sbidoul deleted the wheel-builder-disentangle-6-sbi branch December 29, 2019 10:48
@sbidoul
Copy link
Member Author

sbidoul commented Dec 29, 2019

@chrahunt I can continue with moving the should_unpack code path to the install command. Does that sound good?

FYI I tried removing the unpacking, but it's still necessary for WheelDistribution.get_pkg_resources_distribution, which in turn gets called by check_install_conflicts via _simulate_installation_of.

@chrahunt
Copy link
Member

Yup, sounds good to me. Regarding get_pkg_resources_distribution, I noticed the same and am working on getting metadata directly from the wheel to accommodate it.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jan 28, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation type: refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants