Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing error logging in WheelBuilder #7484

Merged
merged 5 commits into from
Dec 18, 2019
Merged

Add missing error logging in WheelBuilder #7484

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f60d15c
Add missing error report
sbidoul Dec 14, 2019
5de1d51
Ensure output directory is present inside _build_one
sbidoul Dec 14, 2019
2f12534
Remove now redundant ensure_dir
sbidoul Dec 14, 2019
45222a2
ensure cache dir is present before building
sbidoul Dec 15, 2019
2a1fb91
Remove useless pass statement
sbidoul Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions src/pip/_internal/wheel_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,15 @@ def _build_one(

:return: The filename of the built wheel, or None if the build failed.
"""
try:
ensure_dir(output_dir)
except OSError as e:
logger.warning(
"Building wheel for %s failed: %s",
req.name, e,
)
return None

# Install build deps into temporary directory (PEP 518)
with req.build_env:
return self._build_one_inside_env(req, output_dir)
Expand Down Expand Up @@ -375,8 +384,11 @@ def _build_one_inside_env(
wheel_hash.hexdigest())
logger.info('Stored in directory: %s', output_dir)
return dest_path
except Exception:
pass
except Exception as e:
logger.warning(
"Building wheel for %s failed: %s",
req.name, e,
)
# Ignore return, we can't do anything else useful.
self._clean_one(req)
return None
Expand Down Expand Up @@ -439,16 +451,6 @@ def build(
with indent_log():
build_success, build_failure = [], []
for req, cache_dir in buildset:
try:
ensure_dir(cache_dir)
except OSError as e:
logger.warning(
"Building wheel for %s failed: %s",
req.name, e,
)
build_failure.append(req)
continue

wheel_file = self._build_one(req, cache_dir)
if wheel_file:
if should_unpack:
Expand Down