Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old workaround for Ubuntu Python patch #7401

Merged

Conversation

chrahunt
Copy link
Member

@chrahunt chrahunt commented Nov 25, 2019

This was originally implemented for #1074. Essentially:

  1. virtualenvs in /usr/local on Ubuntu 12.04 LTS were suffering because an unconditional replacement on the path was done in the patched sysconfig module available with the system Python.
  2. This was fixed in 14.04 LTS Python 2.7.6 per the diff here (line 51409)

Given that 12.04 LTS has been out of support for 2 years, let's remove this workaround to avoid having to add this error checking to packaging.tags or wrap our usage of the library.

Progresses #6908.

@chrahunt chrahunt added skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes labels Nov 25, 2019
@chrahunt chrahunt changed the title Remove old workaround for Debian Python patch Remove old workaround for Ubuntu Python patch Nov 25, 2019
@chrahunt chrahunt marked this pull request as ready for review November 25, 2019 23:49
@chrahunt chrahunt merged commit 5ba7028 into pypa:master Nov 26, 2019
@chrahunt chrahunt deleted the maint/dont-guard-against-sysconfig-issue branch November 26, 2019 03:58
@chrahunt
Copy link
Member Author

Thanks for reviewing. :)

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants