Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor platform getter functions out of get_supported #7370

Merged
merged 3 commits into from
Nov 19, 2019

Conversation

chrahunt
Copy link
Member

Pulling some easy-to-reason-about pieces out of #7354.

Progresses #6908.

@chrahunt chrahunt added type: refactor Refactoring code skip news Does not need a NEWS file entry (eg: trivial changes) labels Nov 17, 2019
@chrahunt chrahunt marked this pull request as ready for review November 17, 2019 01:00
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Nov 19, 2019
@chrahunt chrahunt force-pushed the refactor/cleanup-get-supported-2 branch from 06f334d to 2af6112 Compare November 19, 2019 00:31
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Nov 19, 2019
@chrahunt chrahunt merged commit e5a3509 into pypa:master Nov 19, 2019
@chrahunt chrahunt deleted the refactor/cleanup-get-supported-2 branch November 19, 2019 01:18
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants