Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python <2.7.9 #7362

Closed
wants to merge 4 commits into from
Closed

Drop support for Python <2.7.9 #7362

wants to merge 4 commits into from

Conversation

pradyunsg
Copy link
Member

Closes #4350

@pradyunsg pradyunsg added the type: maintenance Related to Development and Maintenance Processes label Nov 16, 2019
@pradyunsg pradyunsg mentioned this pull request Nov 16, 2019
Closed
@hugovk
Copy link
Contributor

hugovk commented Nov 16, 2019

In addition to the TLS code, some other candidates for removal:

src/pip/_internal/req/req_file.py:    # Prior to 2.7.3, shlex cannot deal with unicode entries
src/pip/_internal/req/req_uninstall.py:        # "\\server\share\folder". Python 2.7.8+ support UNC in splitdrive.
src/pip/_internal/vcs/bazaar.py:        # This is only needed for python <2.7.5
src/pip/_internal/vcs/versioncontrol.py:        # Python >= 2.7.4, 3.3 doesn't have uses_fragment

@uranusjr
Copy link
Member

Can also remove utils.compat.expanduser. The bug it works around has been fixed since 3.4 (already dropped) and 2.7.3.

@pradyunsg
Drop pip._internal.utils.compat.expanduser
b9c22ef 
The bug it works around, has been fixed since 2.7.4 (and 3.4.0).
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Dec 24, 2019
@pradyunsg pradyunsg closed this Apr 19, 2020
@pradyunsg pradyunsg deleted the drop-python-2.7.9 branch April 19, 2020 18:20
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation needs rebase or merge PR has conflicts with current master type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Python < 2.7.9
4 participants
@pradyunsg @hugovk @uranusjr @BrownTruck