Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 32-bit Linux running on 64-bit ARM arch. #7352

Closed
wants to merge 1 commit into from

Conversation

xuhdev
Copy link

@xuhdev xuhdev commented Nov 14, 2019

A 32-bit Linux running on 64-bit ARM arch should have platform "linux_armv7l".

Currently on a 32-bit OS that runs on a 64-bit ARM CPU (ARM-v8, aarch64), pip installing a armv7l wheel gives the following error message:

foo_armv7l.wheel is not a supported wheel on this platform.

This is caused by a misjudgment of the platform in pip: pip judges the system to be armv8/aarch64, but the system is actually armv7l, which is 32-bit. This PR fixes this issue by following the solution similar to that of the x86_64/x86 pair.

A 32-bit Linux running on 64-bit ARM arch should have platform "linux_armv7l".
@chrahunt
Copy link
Member

Can you provide any context for this change? As-is it is very hard to evaluate this. Also note #6908 - it may be better to submit this to pypa/packaging.

@chrahunt chrahunt added the S: awaiting response Waiting for a response/more information label Nov 14, 2019
@xuhdev
Copy link
Author

xuhdev commented Nov 14, 2019

@chrahunt I've updated the original comment to show more info. Thanks!

@chrahunt chrahunt removed the S: awaiting response Waiting for a response/more information label Nov 14, 2019
@chrahunt
Copy link
Member

Thanks! Can you submit this to pypa/packaging instead? We're removing pep425tags soon and using packaging.tags. Our next release is January so this wouldn't get in before we make that change and we'd want to make sure the quality is up to those standards (e.g. tests).

@xuhdev
Copy link
Author

xuhdev commented Nov 14, 2019

@chrahunt Thanks, I've created a PR at pypa/packaging#234

@xavfernandez
Copy link
Member

Closing in favor of pypa/packaging#234

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants