Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make versions argument singular for pep425tags.get_supported() #7342

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

chrahunt
Copy link
Member

This simplifies the interface of this function in preparation for
switching to packaging.tags.

Progresses #6908.

@chrahunt chrahunt added type: refactor Refactoring code skip news Does not need a NEWS file entry (eg: trivial changes) labels Nov 12, 2019
@chrahunt chrahunt marked this pull request as ready for review November 12, 2019 02:57
src/pip/_internal/pep425tags.py Outdated Show resolved Hide resolved
This simplifies the interface of this function in preparation for
switching to packaging.tags.
@chrahunt chrahunt merged commit 6bc7a1c into pypa:master Nov 13, 2019
@chrahunt chrahunt deleted the refactor/simplify-tags branch November 13, 2019 02:50
@chrahunt
Copy link
Member Author

Thanks for reviewing @xavfernandez!

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants