Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate --skip-requirements-regex #7298

Merged

Conversation

chrahunt
Copy link
Member

@chrahunt chrahunt commented Nov 4, 2019

Supersedes #7188.

Fixes (?) #7297. Process-wise do we leave this issue open until removal so it can be commented on or close it with this PR?

@chrahunt chrahunt added the type: deprecation Related to deprecation / removal. label Nov 4, 2019
@chrahunt chrahunt marked this pull request as ready for review November 5, 2019 00:03
@chrahunt chrahunt merged commit ef20309 into pypa:master Nov 5, 2019
@chrahunt chrahunt deleted the remove/deprecate-skip-requirements-regex branch November 5, 2019 12:54
@chrahunt
Copy link
Member Author

chrahunt commented Nov 5, 2019

Thanks for reviewing! Should the issue be left open until the feature is removed to gather feedback?

@xavfernandez
Copy link
Member

Should the issue be left open until the feature is removed to gather feedback?

Since the deprecation warning will mention it and the auto-lock bot will lock it before pip 20.1 is released if we close it, I think we should keep it open.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation type: deprecation Related to deprecation / removal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants