Remove pip._internal.download #7187
Conversation
chrahunt
added
type: refactor
chrahunt
force-pushed
the
refactor/move-get-file-content
branch
2 times, most recently
from
0da5c7a
to
7f6c321
Compare
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
chrahunt
force-pushed
the
refactor/move-get-file-content
branch
from
7f6c321
to
42ad7a1
Compare
chrahunt
force-pushed
the
refactor/move-get-file-content
branch
from
42ad7a1
to
4f4d7a9
Compare
The only user of this module is operations.prepare.RequirementPreparer. Moving the functionality to the single using module means that refactoring will be easier (since all the mess is in one place). This also removes a mis-named module from the top-level of the repository.
chrahunt
force-pushed
the
refactor/move-get-file-content
branch
from
4f4d7a9
to
5c5c6ec
Compare
|
Does this need to be split up? Every trivial change to download requires a rebase. 😩 |
|
Ah well... Is someone going to work on the debt that this introduces? If not, I'm inclined to suggest that we leave these separate for now -- we can get rid of the rest of |
|
Yes, I plan to - specifically, factoring the hash calculation and download directory handling responsibility out of preparer and the associated functions. |
|
Awesome! Let's do this then! :) |
lock
bot
added
the
auto-locked
Moves the last of its contents as described in #7145 (comment).
This increases the size of
pip._internal.operations.prepare, but now it should be easier to refactor since the not-really-generic functions are alongside their sole caller.Fixes #6813.