Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new YAML tests #7126

Closed
wants to merge 2 commits into from
Closed

Conversation

pradyunsg
Copy link
Member

Built on top of #7125

@pradyunsg pradyunsg added C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes) labels Oct 1, 2019
@pradyunsg pradyunsg force-pushed the tests/new-yaml-tests branch from 269fa0f to c6aa5cf Compare October 1, 2019 06:16
This is based on a CocoaPods test case, which is linked to from the
relevant file.
@pradyunsg pradyunsg force-pushed the tests/new-yaml-tests branch from c6aa5cf to 39e6073 Compare October 6, 2019 12:22
Comment on lines +25 to +29
- A 1.4.0
- B 0.3.5
- C 3.2
- D 0.9.8
- my_app 1.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth indicating why this is the expected behavior in a comment? The comment could be at the top of the file describing the situation in plain words, or above the individual available packages indicating the intention behind their specific dependencies.

@pradyunsg pradyunsg closed this Apr 8, 2020
@pradyunsg pradyunsg deleted the tests/new-yaml-tests branch April 8, 2020 13:57
@pradyunsg pradyunsg restored the tests/new-yaml-tests branch April 8, 2020 13:57
@pradyunsg pradyunsg deleted the tests/new-yaml-tests branch April 19, 2020 18:20
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants