Move run_egg_info into operations.generate_metadata #7063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it was a little difficult to follow. Because the comments weren't helpful unless you've built enough context.
pradyunsg
added
type: refactor
pradyunsg
commented
Sep 22, 2019
chrahunt
approved these changes
Sep 22, 2019
chrahunt
reviewed
Sep 22, 2019
| from pip._internal.utils.typing import MYPY_CHECK_RUNNING | ||
|
|
||
| if MYPY_CHECK_RUNNING: | ||
| from typing import Callable | ||
| from typing import Callable, List | ||
| from pip._internal.req.req_install import InstallRequirement |
There was a problem hiding this comment.
I would put an empty line above this, it can be rolled into the next one if you like.
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7051