Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to GitHub Actions CI/CD workflow #6953

Conversation

webknjaz
Copy link
Member

Trying to figure out how hard it is to make actions run tests...

@webknjaz

This comment has been minimized.

@webknjaz webknjaz force-pushed the features/integrate-github-actions-ci-cd--tests branch 5 times, most recently from 331ef38 to 2418bc8 Compare January 17, 2020 01:48
@webknjaz webknjaz force-pushed the features/integrate-github-actions-ci-cd--tests branch 14 times, most recently from ea96d0a to 57a1fe5 Compare January 18, 2020 17:25
@webknjaz webknjaz force-pushed the features/integrate-github-actions-ci-cd--tests branch from 57a1fe5 to dc935c4 Compare January 18, 2020 17:28
@webknjaz webknjaz requested a review from pradyunsg January 18, 2020 17:38
@webknjaz webknjaz marked this pull request as ready for review January 18, 2020 17:39
@chrahunt
Copy link
Member

Thank you!

Related to #7279. A few comments/questions about this change specifically:

  1. What CI providers are we trying to displace with these tests?
  2. We should understand what impact this has for running tests on multiple PRs. From here it looks like we get up to 20 concurrent jobs and 5 macOS jobs for free as an open-source project. Compared to 30 on Azure Pipelines and I'm not sure about Travis
  3. Is there a way to publish and query our test run info? One benefit of Azure Pipelines is the test analysis tools and API available for querying test information for each run, see here for example.

@webknjaz
Copy link
Member Author

@chrahunt

  1. This is not trying to displace CIs but rather extend envs coverage. Each CI provider has its own way of setting up VMs which may result in discovering some weird cases reproducible only under one env, for example.
  2. This question makes sense if the checks are required by the branch protection rules. Otherwise, it's yet another set of advisory checks.
  3. I don't think so. I think it should be possible to emulate test report tables via Checks API but this would require a bit of extra coding.

@pradyunsg
Copy link
Member

This question makes sense if the checks are required by the branch protection rules. Otherwise, it's yet another set of advisory checks.

I think @chrahunt meant, what is the effect if multiple PRs are opened at the same time -- how much of a slowdown would this entail?

@webknjaz
Copy link
Member Author

I think @chrahunt meant, what is the effect if multiple PRs are opened at the same time -- how much of a slowdown would this entail?

Ah, not much I think.

Compare these:

Since GH workflows run in parallel with Azure, I'd say that they'll finish faster, hence no slow-down. Also, I've set fail-fast: false because it's easier to debug stuff this way. If we remove it, failed tests will abort the whole workflow faster.

@webknjaz
Copy link
Member Author

webknjaz commented Feb 1, 2020

@chrahunt @pradyunsg how do we advance this now?

@pradyunsg
Copy link
Member

@chrahunt @pradyunsg how do we advance this now?

Let's have a discussion in #7279 about what we want our CI situation to look like.

@pradyunsg pradyunsg added the state: blocked Can not be done until something else is done label Feb 6, 2020
@pradyunsg
Copy link
Member

I'm gonna say this is blocked on #7279, since once we know how we want to do CI, we'll pick the relevant parts from this PR. :)

@pradyunsg pradyunsg added C: automation Automated checks, CI etc type: maintenance Related to Development and Maintenance Processes labels Feb 6, 2020
@pradyunsg
Copy link
Member

Closing since:

@pradyunsg pradyunsg closed this Sep 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: automation Automated checks, CI etc state: blocked Can not be done until something else is done type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants