Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic debug doc #6731

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Add basic debug doc #6731

merged 2 commits into from
Jul 18, 2019

Conversation

xavfernandez
Copy link
Member

Closes #6672

@xavfernandez xavfernandez changed the title Xfernandez/add basic debug doc Add basic debug doc Jul 18, 2019
@xavfernandez xavfernandez added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jul 18, 2019
@xavfernandez xavfernandez mentioned this pull request Jul 18, 2019
Closed
pradyunsg
pradyunsg reviewed Jul 18, 2019
View reviewed changes
docs/man/commands/debug.rst Outdated Show resolved Hide resolved
docs/man/commands/debug.rst Outdated Show resolved Hide resolved
@xavfernandez xavfernandez force-pushed the xfernandez/add_basic_debug_doc branch from bf2a482 to 86944ad Compare July 18, 2019 09:37
@xavfernandez
Copy link
Member Author

Thanks @pradyunsg 🙈

@xavfernandez xavfernandez force-pushed the xfernandez/add_basic_debug_doc branch from 86944ad to aa31fca Compare July 18, 2019 09:39
@pradyunsg
Copy link
Member

We'd want to add a man page for this as well. :)

@xavfernandez xavfernandez force-pushed the xfernandez/add_basic_debug_doc branch from aa31fca to 368e175 Compare July 18, 2019 09:51
@xavfernandez
Copy link
Member Author

xavfernandez commented Jul 18, 2019 •
edited
Loading

We'd want to add a man page for this as well. :)

Is there something more to do than add docs/man/commands/debug.rst (the file you commented on 🙄 ) ?

@pradyunsg
Copy link
Member

Uhm... I'm sleepy. :)

@xavfernandez xavfernandez force-pushed the xfernandez/add_basic_debug_doc branch from 368e175 to ab10b8c Compare July 18, 2019 12:39
cjerdonek
cjerdonek approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@cjerdonek cjerdonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@pradyunsg pradyunsg merged commit e916124 into pypa:master Jul 18, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Aug 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 17, 2019
@xavfernandez xavfernandez deleted the xfernandez/add_basic_debug_doc branch January 10, 2020 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pfmoore pfmoore pfmoore left review comments

@pradyunsg pradyunsg pradyunsg left review comments

@cjerdonek cjerdonek cjerdonek approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docs for new pip debug command
4 participants
@xavfernandez @pradyunsg @cjerdonek @pfmoore