Improve the debug log message when installing an incompatible wheel #6540
Conversation
cjerdonek
added
C: logging
cjerdonek
force-pushed
the
issue-6121-incompatible-wheel-message
branch
2 times, most recently
from
539eaae to
5b98752
Compare
cjerdonek
force-pushed
the
issue-6121-incompatible-wheel-message
branch
from
5b98752 to
a9a9cfd
Compare
| assert ( | ||
| 'Skipping link: not a file: {}'.format(data.find_links) in | ||
| result.stdout | ||
| ), 'stdout: {}'.format(result.stdout) |
There was a problem hiding this comment.
IIRC this can just be , result, right?
There was a problem hiding this comment.
I tried this out, and what happens is it adds other sections of info like -- stderr: ---, -- created: ----, and -- updated: --- (in addition to -- stdout: ----). Since those other sections can also be long and aren't needed, I think it might be better not to include them.
There was a problem hiding this comment.
I'd say they're useful diagnostic information (like an error getting logged on stderr by the networking stuff) or something like that.
I'll leave it to you to decide on what to include here since it's not worth too long a discussion anyway.
There was a problem hiding this comment.
I'll just leave it off. Normally, the test runner includes lots of surrounding info already. It's just when you can't see the string being checked against where it gets annoying (which was the reason for adding it) -- because it truncates long strings.
| assert ( | ||
| 'Skipping link: not a file: {}'.format(data.find_links) in | ||
| result.stdout | ||
| ), 'stdout: {}'.format(result.stdout) |
|
Thanks a lot for reviewing, by the way. |
lock
bot
added
the
auto-locked
This PR addresses the following issue mentioned in #6121 by including in the debug message the tags of the wheel that was incompatible: