Change PackageFinder to accept py_version_info instead of python_versions #6539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
added
C: finder
cjerdonek
changed the title
xavfernandez
approved these changes
May 27, 2019
cjerdonek
force-pushed
the
package-finder-version-info
branch
from
a2c4123
to
798d814
Compare
|
@xavfernandez Thanks again for reviewing. I incorporated your suggested change. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring PR to change how
PackageFinderaccepts and stores the--python-versionpassed to it. The change is to pass a tuple of ints like(3, 6)rather than a list of strings['36']as it is currently doing. (For example, a list isn't actually needed since there is only ever at most one element.) This will be useful for issues like #5369 and #6117 (with PR #6357) and also makes the code easier to understand and work with.