Move _link_package_versions() to CandidateEvaluator #6425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
added
C: finder
cjerdonek
force-pushed
the
move-link-package-versions
branch
2 times, most recently
from
064862c to
72e8574
Compare
cjerdonek
force-pushed
the
move-link-package-versions
branch
from
72e8574 to
b1e3849
Compare
uranusjr
reviewed
Apr 23, 2019
uranusjr
reviewed
Apr 23, 2019
src/pip/_internal/index.py
Outdated
| def is_wheel_supported(self, wheel): | ||
| self._py_version_re = re.compile(r'-py([123]\.?[0-9]?)$') | ||
| # These are boring links that have already been logged somehow: | ||
| self.logged_links = set() # type: Set[Link] |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
cjerdonek
force-pushed
the
move-link-package-versions
branch
from
b1e3849 to
1d89051
Compare
cjerdonek
force-pushed
the
move-link-package-versions
branch
from
1d89051 to
10c68e6
Compare
|
Okay, I posted a new version that addresses @uranusjr's comments. |
uranusjr
approved these changes
May 8, 2019
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on to PR #6424 and is also a refactor. It stems from the following comment: #6424 (comment)