Finder found candidates cleanup #6415
Conversation
src/pip/_internal/index.py
Outdated
| @@ -288,22 +317,10 @@ def iter_all(self): | |||
|
|
|||
| def iter_applicable(self): | |||
| # type: () -> Iterable[InstallationCandidate] | |||
| """Iterate through candidates matching the given specifier. | |||
| """Iterate through candidates matching the given versions. | |||
There was a problem hiding this comment.
I would say something other than "given" here because the versions are associated with the object rather than given as arguments (which is what given normally means in the context of a function or method docstring).
There was a problem hiding this comment.
Is the current wording better? (I am not good at describing things.)
There was a problem hiding this comment.
It's not a big deal. But some other possibilities that come to mind: "Iterate through the candidates matching the instance's versions." or "matching the versions associated with the instance" or "matching the associated versions"
cjerdonek
added
C: finder
uranusjr
force-pushed
the
finder-found-candidates-cleanup
branch
from
650d3ee to
f499e11
Compare
uranusjr
force-pushed
the
finder-found-candidates-cleanup
branch
from
f499e11 to
288f5b9
Compare
|
Changed the default specifier arg to None, and store versions as Set[str] instead. |
|
Good work! 👍Looks great! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Follow-up cleaning mentioned in #5971