-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address #6197: use the ephemeral cache if we need to when autobuilding #6219
Conversation
c963358
to
e49e1ef
Compare
e49e1ef
to
e36ea42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is the right approach. This seems like another of pip's cause is far from effect regressions. :(
I've really not had enough time to take a good look at this situation yet to be sure though.
e36ea42
to
64e5b03
Compare
@pradyunsg I made the change. Could it just be a matter of passing a boolean flag to |
@uranusjr Can you take a look at this issue and PR since you had taken a look at this part when refactoring out |
64e5b03
to
f2a6285
Compare
4aa81df
to
b228fba
Compare
@pradyunsg I added my idea for the fix that I said in my last comment to you. You can see what the change was by looking at the second commit in the sequence. I also verified that this change works against the Dockerfile reproducer that was posted in the original issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a quick-fix.
I'm still concerned if there's some issue with the "preparation" of the requirements but I genuinely don't have bandwidth for the next few days.
news/6197.bugfix
Outdated
@@ -0,0 +1,2 @@ | |||
Fix the ``have_directory_for_build`` ``AssertionError`` when using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rephrase this to:
Fix a crash where PEP 517-based builds would fail due to not finalizing
a build directory internally, resulting in an ``AssertionError``.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted the news entry along these lines and added some more test cases (by parametrizing the original test).
259476d
to
2d9d3ff
Compare
The logic looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go.
pip has to be at least version 19.0.2, which fixes a have_directory_for_build AssertionError when installing with PIP_NO_CACHE_DIR set. The updated image comes with pip 19.0.3. See pypa/pip#6219 for more info.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Failing test followed by proposed fix for #6197.