Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/19.0 #6155

Merged
merged 7 commits into from
Jan 22, 2019
Merged

Release/19.0 #6155

merged 7 commits into from
Jan 22, 2019

Conversation

pradyunsg
Copy link
Member

This is fun. While the tests run, I'll grab a bite and... draft the announcement. :)

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 22, 2019
@pradyunsg pradyunsg added this to the 19.0 milestone Jan 22, 2019
@cjerdonek
Copy link
Member

cjerdonek commented Jan 22, 2019

@pradyunsg I don’t see the NEWS entry for the broken stdout pipe PR #5907 that was merged a couple days ago. Do you know why it’s not there?

@pradyunsg
Copy link
Member Author

Yeah, that's what I was checking -- the packaging NEWS entry is also missing.

@pradyunsg
Copy link
Member Author

pradyunsg commented Jan 22, 2019

Looks like I hadn't pulled the latest master on my fork. I messed up on step 1. 😅

Should be a trivial redo, given that most of the work is basically done anyway. Thanks for pointing this out @cjerdonek!

@pradyunsg
Copy link
Member Author

Ok, we're golden. Let's build.

@pradyunsg pradyunsg merged commit acdbcf7 into pypa:master Jan 22, 2019
@pradyunsg pradyunsg deleted the release/19.0 branch January 22, 2019 19:15
@lock
Copy link

lock bot commented May 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants