Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue5963 #6025

Closed
wants to merge 6 commits into from
Closed

Issue5963 #6025

wants to merge 6 commits into from

Conversation

Albert-Guan
Copy link
Contributor

This pr fixes problem in ISSUE #5963
The reason that the internal error happens is: clients are trying to set a virtual env config variable but it is not under virtual environment. Add better error message to help clients find what they need to do when the error happens.
Also the same problem will happen when clients are trying to set a user config variable but enable the isolated mode at the same time. Also add better error message for it.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label May 14, 2019
@BrownTruck BrownTruck removed the needs rebase or merge PR has conflicts with current master label Jul 24, 2019
@chrahunt
Copy link
Member

chrahunt commented Aug 7, 2019

It looks like this has been fixed by #6491.

@chrahunt chrahunt added the S: awaiting response Waiting for a response/more information label Aug 16, 2019
@chrahunt
Copy link
Member

chrahunt commented Sep 3, 2019

Hi @Albert-Guan. I will close this as fixed by the other issue, but please reach out if that doesn't sound right to you. Thank you!

@chrahunt chrahunt closed this Sep 3, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation S: awaiting response Waiting for a response/more information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants