Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip freeze: skip current directory by default #5951

Closed
wants to merge 1 commit into from
Closed

pip freeze: skip current directory by default #5951

wants to merge 1 commit into from

Conversation

kaikulimu
Copy link

In response to #2926

@kaikulimu kaikulimu mentioned this pull request Oct 27, 2018
Closed
@cjerdonek cjerdonek added type: enhancement Improvements to functionality C: freeze 'pip freeze' related labels Oct 27, 2018
@pradyunsg
Copy link
Member

Could you add a test for this?

@kaikulimu kaikulimu changed the title pip freeze: skip local directory by default pip freeze: skip current directory by default Oct 28, 2018
@kaikulimu kaikulimu force-pushed the freeze-skip-curr-dir branch 2 times, most recently from 45a19da to 93956d5 Compare October 28, 2018 22:14
@kaikulimu
Copy link
Author

Added test, and made some modifications.

@kaikulimu kaikulimu force-pushed the freeze-skip-curr-dir branch 2 times, most recently from 0e0bca9 to 799c8fe Compare October 29, 2018 02:03
@kaikulimu kaikulimu force-pushed the freeze-skip-curr-dir branch from 799c8fe to fc456df Compare October 29, 2018 02:28
@pradyunsg
Copy link
Member

Ci is failing on this PR.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Dec 8, 2018
@pradyunsg
Copy link
Member

Thanks for this PR!

I'm closing this PR since it's bitrotten. Please file a new PR if there's still interest in this.

@pradyunsg pradyunsg closed this May 23, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: freeze 'pip freeze' related needs rebase or merge PR has conflicts with current master type: enhancement Improvements to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaikulimu @pradyunsg @BrownTruck @cjerdonek