Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: temporarily pin pytest to fix AppVeyor builds #5896

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

benoit-pierre
Copy link
Member

No description provided.

@benoit-pierre
Copy link
Member Author

Can this be merged? I have a workaround for not hitting the limit even with pytest>3.8.2, but it's rather more involved.

@cjerdonek
Copy link
Member

Can you add a trivial news entry so a green checkmark will be visible for this commit?

@cjerdonek cjerdonek added the C: tests Testing and related things label Oct 18, 2018
@benoit-pierre
Copy link
Member Author

Or you could add the trivial label :P

@pfmoore pfmoore added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 18, 2018
@pfmoore pfmoore merged commit c30b10a into pypa:master Oct 18, 2018
@cjerdonek
Copy link
Member

Oh, I didn't know about that feature. :)

@benoit-pierre benoit-pierre deleted the temporary_appveyor_fix branch October 18, 2018 21:27
@pradyunsg
Copy link
Member

pradyunsg commented Oct 19, 2018

It's noted in the docs for news entries.

Which reminds me, @cjerdonek have you been added to the other platforms like RTD? There's a list in the dev docs.

@cjerdonek
Copy link
Member

cjerdonek commented Oct 19, 2018

It's noted in the docs for news entries.

Yes, I see that now. Part of my surprise was that the label can be added even after tests are run, and it will go back and change the test result. I was thinking it needed to be added beforehand. (I also now know that you can trigger tests to be re-run by closing and re-opening the issue.)

@cjerdonek
Copy link
Member

have you been added to the other platforms like RTD?

I don't think so. Something else I don't see on that list is reference to the PyPA-Committers mailing list.

@cjerdonek
Copy link
Member

I have a workaround for not hitting the limit even with pytest>3.8.2, but it's rather more involved.

I wonder if pytest could expose or change something to make it easier to work around this issue..

@pradyunsg
Copy link
Member

@cjerdonek We should smoothen our "on-boarding process" for new committers but then again, it doesn't really happen often enough.

If there's any improvement in language to that text that would have helped you, a PR would be nice. :)

IIRC, @dstufft is the right person to put up a mail to, for adding you to pypa-committers. It's really a temporary measure for figuring out some things over the short term so I don't want to get that documented. I'll come around to adding you on the documented platforms myself, before the Bloomberg Sprint happens otherwise during it.

@lock
Copy link

lock bot commented May 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants