Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ZipFile.open instead of ZipFile.read #5848

Merged
merged 4 commits into from
Oct 19, 2018
Merged

Use ZipFile.open instead of ZipFile.read #5848

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
643eee1
Use ZipFile.open instead of ZipFile.read
waveform80 Oct 4, 2018
c0d3e14
Address comments in PR
waveform80 Oct 12, 2018
864287e
Shorten commentary
waveform80 Oct 12, 2018
64f0897
Single line news entry
waveform80 Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pip/_internal/utils/misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,6 @@ def unzip_file(filename, location, flatten=True):
leading = has_leading_dir(zip.namelist()) and flatten
for info in zip.infolist():
name = info.filename
data = zip.read(name)
fn = name
if leading:
fn = split_leading_dir(name)[1]
Expand All @@ -479,9 +478,10 @@ def unzip_file(filename, location, flatten=True):
ensure_dir(fn)
else:
ensure_dir(dir)
fp = open(fn, 'wb')
fp = zip.open(name)
waveform80 marked this conversation as resolved.
Show resolved Hide resolved
try:
fp.write(data)
with open(fn, 'wb') as destfp:
shutil.copyfileobj(fp, destfp)
finally:
fp.close()
mode = info.external_attr >> 16
Expand Down