Warn when dropping index URL value to directory #5836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
bugfix-warn-directory-path-drop-index-url
branch
from
1ac5caf
to
5ccbf49
Compare
cjerdonek
approved these changes
Oct 1, 2018
src/pip/_internal/index.py
Outdated
| else: | ||
| logger.warning( | ||
| "Path '{0}' is ignored: " | ||
| "it is a directory.".format(url), |
There was a problem hiding this comment.
Nit: this should be path (though they should be equal), right?
There was a problem hiding this comment.
Gosh, uh, I… guess? Since the outer condition specifies is_local_path or is_file_url, but the one above takes is_file_url, so this leaves only is_local_path and not is_file_url, which would have triggered path = url. It’s so difficult to keep this straight.
uranusjr
force-pushed
the
bugfix-warn-directory-path-drop-index-url
branch
from
5ccbf49
to
8dcae5b
Compare
cjerdonek
added
type: enhancement
|
@pradyunsg Can this go in, too? |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5827. I opt to only add the warning for now instead of refactoring the whole thing.
expand_diradds a lot of complexity to this function, and I want to eliminate it first. I think it would be easier to get the function to work “properly” before changing how its invoked.