Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give specific error on connnection failure #5663

Closed
wants to merge 2 commits into from
Closed

Give specific error on connnection failure #5663

wants to merge 2 commits into from

Conversation

aimileus
Copy link

Pip gives a generic error message at the moment, if it is unable to connect to the internet. This same error message is given if pip tries to download a package which does not exist. This commit gives a specific error message if pip is unable to connect to the server, to make clear what the error is.

@pradyunsg pradyunsg added the S: needs triage Issues/PRs that need to be triaged label Jul 29, 2018
aimileus added 2 commits August 3, 2018 11:11
@aimileus
Give specific error on connnection failure
867c907 
Pip gives a generic error message at the moment, if it is unable to
connect to the internet. This same error message is given if pip tries
to download a package which does not exist. This commit gives a specific
error message if pip is unable to connect to the server, to make clear
what the error is.
@aimileus
Split line of 80 characters
0d63d70
@chrahunt
Copy link
Member

chrahunt commented Jul 5, 2019

This concern should probably be raised as an issue, with the specific command, network scenario, and current warning/error message provided. As-is it is very difficult to evaluate this.

@chrahunt
Copy link
Member

Related to #3642.

@chrahunt chrahunt added S: awaiting response Waiting for a response/more information and removed S: needs triage Issues/PRs that need to be triaged labels Aug 16, 2019
@chrahunt
Copy link
Member

Hi @aimileus. I will close this PR since it can't really be evaluated in its current state. Please feel free to join the discussion over in #3642 where we can identify the error scenarios and messages that would make this easier for users.

@chrahunt chrahunt closed this Aug 25, 2019
@chrahunt chrahunt removed the S: awaiting response Waiting for a response/more information label Aug 25, 2019
@aimileus aimileus deleted the no-internet-error branch September 16, 2019 18:09
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Oct 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aimileus @chrahunt @pradyunsg