Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve content in "Creating New Release" section #5653

Merged
merged 2 commits into from
Jul 28, 2018

Conversation

pradyunsg
Copy link
Member

Towards #5633

I didn't break the PR into individual commits since the change is prose and is small enough.

  • Break up points that involve checking out git refs
  • Include supporting comment for bumping version
  • Drop outdated reference to "CHANGES.txt"
  • Provide a link to get-pip repository
  • Drop the outdated get-pip.py generation command
  • Mention that even the git tag has to be pushed
  • Put all commmands that can be executed in parenthesis

- Break up points that involve checking out git refs
- Include supporting comment for bumping version
- Drop outdated reference to "CHANGES.txt"
- Provide a link to get-pip repository
- Drop the outdated get-pip.py generation command
- Put all commmands that can be executed in parenthesis
@pradyunsg pradyunsg added type: docs Documentation related skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes labels Jul 24, 2018
@pradyunsg pradyunsg added this to the Internal Cleansing milestone Jul 24, 2018
@pradyunsg pradyunsg self-assigned this Jul 24, 2018
@pradyunsg
Copy link
Member Author

Rendered Version Images

Before:

screen shot 2018-07-24 at 5 59 00 pm

After:

screen shot 2018-07-24 at 6 07 06 pm

docs/development/release-process.rst Outdated Show resolved Hide resolved
docs/development/release-process.rst Outdated Show resolved Hide resolved
docs/development/release-process.rst Outdated Show resolved Hide resolved
docs/development/release-process.rst Outdated Show resolved Hide resolved
@pradyunsg
Copy link
Member Author

@pfmoore Could you take a look again?

@pradyunsg pradyunsg dismissed pfmoore’s stale review July 28, 2018 16:09

Changes addressed, I think.

@pradyunsg pradyunsg merged commit 3e81d8c into pypa:master Jul 28, 2018
@pradyunsg pradyunsg deleted the docs/update-release-process branch July 28, 2018 17:52
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: docs Documentation related type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants