Adjust the deprecation policy to be time based #5572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
the
type: maintenance
|
LGTM, other than the wrapping of the text being longer than the rest of the document. |
dstufft
force-pushed
the
deprecation-process
branch
from
35d0315 to
fde9eb6
Compare
pradyunsg
reviewed
Jul 6, 2018
| be changed without warning, or any deprecation period, in a pip release. | ||
| However, we are aware that the documentation isn't always complete - PRs that | ||
| document existing behaviour with the intention of covering that behaviour with | ||
| document existing behavior with the intention of covering that behavior with |
There was a problem hiding this comment.
Aha. British English and American English spellings. 😄
pradyunsg
reviewed
Jul 8, 2018
| periods, or deprecation warnings for behaviour changes that would not normally | ||
| be covered by this policy, are also possible depending on circumstances, but | ||
| this is at the discretion of the pip developers. | ||
| 6 months before the change occurs. Deprecation will take the form of a warning |
There was a problem hiding this comment.
@dstufft "one released version" is a 3 month period whereas this says 6 months. Is that intentional?
There was a problem hiding this comment.
(I'd noticed the 6 month earlier but I didn't realize the time frame got changed until now.)
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pypa/pip-committers
This came up in #5542, but basically, the current policy is based upon the number of releases, but we don't know exactly how many releases we're going to have, because we may skip releases, etc. Instead this adjusts the policy so that it is time based.
This doesn't really affect the policy much, but it makes it more obvious for end users who aren't familiar with our particular release cadence how long they have to no longer rely on deprecated behavior. It also fits in well with our general assumption that people should be staying on the latest version wherever possible.