Ignore pre-release versions when prompting for upgrade #5470
Conversation
|
Thanks for the PR on this @TheJokersThief! :) @pypa/pip-committers I was wondering if pip should show a message when there's pre-release versions available; asking the user to test them if they can. If we go this way, one case that comes to mind is what should happen when someone's on 18.0, there's an 18.1 and 18.2b1 available? 2 messages? Only one message suggesting the normal upgrade? I'd say 2 messages, as long as they're unambiguously worded. |
pradyunsg
added
type: enhancement
|
@pypa/pip-committers Ping? |
Meh. We have prereleases so infrequently, it's not a big deal. And the lack of experience with having them means any decisions we make about what's the best way of designing it are likely just guesswork. So basically I don't think it's worth it. As to this PR, I don't really mind either way. It's just as easy to ignore the upgrade message if it's offering a pre-release version. |
|
I'd be in favor of merging this and not prompting the user to use a prerelease. |
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
|
This was superseded by PR #5971 (now merged). Thank you for your contribution to addressing this issue! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
This is a PR to solve #5175.
The possible candidates for updating are filtered to remove any versions that contain a pre-release.
I've also updated the unit test to properly reproduce and test for the error. The old values for the versions didn't trigger it but the new versions committed will.