Move out all the config code to a separate module #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor is intended to make it easier to make configuration related improvements in the future, since all the code is in a separated unit. The unit tests have been updated partially to merely update them. They now patch underscore names which means that they probably need updating.
xavfernandez
approved these changes
Dec 21, 2016
|
Just a few pep8 but this looks good 👍 |
|
Done. |
This was referenced Dec 22, 2016
|
Thanks :) |
|
@xavfernandez I added one more commit. Will make a new PR for that. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor is intended to make it easier to make configuration related improvements in the future, since all the code is in a separated unit. Essentially, all the code is refactored out of the option parser into a separate module.
The unit tests have been updated partially to merely update them. They now patch underscore names which means that they probably need updating.