Do a (slightly) less insane thing to handle debundling #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstufft
force-pushed
the
less-insane-vendoring
branch
from
d01bbd8
to
2ffd3af
Compare
Previously we attempt to do some crazy things with import hooks in order to attempt to automatically alias normally installed dependencies as our vendored dependencies. This turned out to be fairly fragile, so instead we'll manually patch sys.modules to trigger the aliasing. As part of this, we also drop support for the PIP_NO_VENDOR_FOR_DOWNSTREAM environment variable because it was never fully supported and now that we have wheel caching, actually using it could possibly trigger a bad wheel to be cached. The new mechanism requires some light patching by downstream to opt into the mechanism, so they can also easily remove all of the files in pip/_vendor/ except for __init__.py.
dstufft
force-pushed
the
less-insane-vendoring
branch
from
2ffd3af
to
2912910
Compare
dstufft
added a commit
that referenced
this pull request
Jun 24, 2015
Do a (slightly) less insane thing to handle debundling
|
LGTM though I haven't tested it. This should make things nicer for Debian since we'll only have to change DEBUNDLED and WHEEL_DIR and can drop the rest of our delta. I'll test it for real a little later, but don't wait for me to merge it. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we attempt to do some crazy things with import hooks in order to attempt to automatically alias normally installed dependencies as our vendored dependencies. This turned out to be fairly fragile, so instead we'll manually patch
sys.modulesto trigger the aliasing.Closes #2896