-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address issue #1236. #2785
Address issue #1236. #2785
Conversation
… Breaking tests are in preparation of a fix for pypa#1236.
…ory-like requirement specifications as well as url requirement specifications.
So this makes
However +1. |
assert len(req.extras) == 2 | ||
assert req.extras[0] == 'ex1' | ||
assert req.extras[1] == 'ex2' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these 4 tests are in the wrong place.
this test class is for processing lines in a requirements file.
you're not testing the process_line
method in these tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looking at it again, I'd probably move them into tests/unit/test_req.py in the TestInstallRequirement class. Does that look more reasonable to you? If so, I can put together a pull request with the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, that would be great, thanks
I'm glad this specification works for tar.gz, and I see it also works for .whl. How do specify extras when I need to install from a URL? The package is listed in a conda environment.yml, and the system in which I'm doing the install requires that I use a URL. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
A potential solution to #1236 where we check for [extra1,extra2] formatted extras at the end of all requirement specifications, either editable or not.
I recreated the commits and pull request to fix the munged contributor when I did the original commits.