Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pyproject_hooks to DEBUNDLED preload list #12796

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Jun 25, 2024

Otherwise, tests fail to load:

ImportError while loading conftest '/tmp/portage/dev-python/pip-24.1-r1/work/pip-24.1/tests/conftest.py'.
tests/conftest.py:49: in <module>
    from pip._internal.utils.temp_dir import global_tempdir_manager
../pip-24.1-python3_13/install/usr/lib/python3.13/site-packages/pip/_internal/utils/temp_dir.py:20: in <module>
    from pip._internal.utils.misc import enum, rmtree
../pip-24.1-python3_13/install/usr/lib/python3.13/site-packages/pip/_internal/utils/misc.py:38: in <module>
    from pip._vendor.pyproject_hooks import BuildBackendHookCaller
E   ModuleNotFoundError: No module named 'pip._vendor.pyproject_hooks'

@pradyunsg pradyunsg changed the title Add missing pyproject_api to DEBUNDLED preload list Add missing pyproject_hooks to DEBUNDLED preload list Jun 25, 2024
@pradyunsg
Copy link
Member

@mgorny
Copy link
Contributor Author

mgorny commented Jun 25, 2024

Ah, sorry, brainfart.

Otherwise, tests fail to load:

```
ImportError while loading conftest '/tmp/portage/dev-python/pip-24.1-r1/work/pip-24.1/tests/conftest.py'.
tests/conftest.py:49: in <module>
    from pip._internal.utils.temp_dir import global_tempdir_manager
../pip-24.1-python3_13/install/usr/lib/python3.13/site-packages/pip/_internal/utils/temp_dir.py:20: in <module>
    from pip._internal.utils.misc import enum, rmtree
../pip-24.1-python3_13/install/usr/lib/python3.13/site-packages/pip/_internal/utils/misc.py:38: in <module>
    from pip._vendor.pyproject_hooks import BuildBackendHookCaller
E   ModuleNotFoundError: No module named 'pip._vendor.pyproject_hooks'
```
@mgorny mgorny force-pushed the debundled-aliases branch from 562fa01 to 9b686fa Compare June 25, 2024 18:50
@sbidoul
Copy link
Member

sbidoul commented Jun 25, 2024

Thanks. Let's remove pep517 from that list at the same time.

@mgorny
Copy link
Contributor Author

mgorny commented Jun 26, 2024

Thnaks. Let's remove pep517 from that list at the same time.

Added.

Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ichard26
Copy link
Member

Ah, this still needs a NEWS entry. This can probably go under the vendor category.

@mgorny
Copy link
Contributor Author

mgorny commented Jun 28, 2024

Ah, this still needs a NEWS entry. This can probably go under the vendor category.

Very well. I thought it's not worth including since FWIU this isn't really a "supported" territory but I'll add one.

@ichard26
Copy link
Member

My line of reasoning is that the vendor category is already obtuse to regular users, so it's likely primarily the downstream redistributors that read the vendor changelog entries. They may want to know about this change, hence my ask for an entry.

news/12796.vendor.rst Outdated Show resolved Hide resolved
@sbidoul
Copy link
Member

sbidoul commented Jul 2, 2024

Pre-commit is complaining, though.

@mgorny
Copy link
Contributor Author

mgorny commented Jul 2, 2024

That's what I get for merging suggestions :-). Lemme fix that quickly.

@sbidoul sbidoul merged commit c25a522 into pypa:main Jul 2, 2024
28 checks passed
@mgorny mgorny deleted the debundled-aliases branch July 2, 2024 06:45
@mgorny
Copy link
Contributor Author

mgorny commented Jul 2, 2024

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants