-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing pyproject_hooks
to DEBUNDLED preload list
#12796
Conversation
pyproject_api
to DEBUNDLED preload listpyproject_hooks
to DEBUNDLED preload list
https://pypi.org/project/pyproject-api/ is not the same as https://pypi.org/project/pyproject-hooks/ :) |
Ah, sorry, brainfart. |
Otherwise, tests fail to load: ``` ImportError while loading conftest '/tmp/portage/dev-python/pip-24.1-r1/work/pip-24.1/tests/conftest.py'. tests/conftest.py:49: in <module> from pip._internal.utils.temp_dir import global_tempdir_manager ../pip-24.1-python3_13/install/usr/lib/python3.13/site-packages/pip/_internal/utils/temp_dir.py:20: in <module> from pip._internal.utils.misc import enum, rmtree ../pip-24.1-python3_13/install/usr/lib/python3.13/site-packages/pip/_internal/utils/misc.py:38: in <module> from pip._vendor.pyproject_hooks import BuildBackendHookCaller E ModuleNotFoundError: No module named 'pip._vendor.pyproject_hooks' ```
562fa01
to
9b686fa
Compare
Thanks. Let's remove pep517 from that list at the same time. |
Added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Ah, this still needs a NEWS entry. This can probably go under the vendor category. |
Very well. I thought it's not worth including since FWIU this isn't really a "supported" territory but I'll add one. |
My line of reasoning is that the vendor category is already obtuse to regular users, so it's likely primarily the downstream redistributors that read the vendor changelog entries. They may want to know about this change, hence my ask for an entry. |
Co-authored-by: Stéphane Bidoul <[email protected]>
Pre-commit is complaining, though. |
That's what I get for merging suggestions :-). Lemme fix that quickly. |
Thanks! |
Otherwise, tests fail to load: