Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report detailed information about invalid requirements #12715

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Report detailed information about invalid requirements #12715

merged 1 commit into from
Jun 10, 2024

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented May 20, 2024

closes #12713

@sbidoul sbidoul added this to the 24.1 milestone May 20, 2024
@sbidoul sbidoul force-pushed the imp-invalid-req-reporting branch from f811eac to ed91272 Compare May 20, 2024 10:35
@sbidoul sbidoul force-pushed the imp-invalid-req-reporting branch from ed91272 to 96d78f1 Compare May 20, 2024 10:54
@sbidoul sbidoul mentioned this pull request May 20, 2024
Closed
1 task
pfmoore
pfmoore approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures appear to be unrelated to this change?

@uranusjr
Copy link
Member

Seems to, GitHub is having trouble fetching VCM repos (even file:// ones) for some reason.

@notatallshaw
Copy link
Member

Test failures have been appearing on multiple PRs for a few days, I noticed but didn't get chance to investigate.

@pradyunsg pradyunsg force-pushed the imp-invalid-req-reporting branch from 96d78f1 to c3434bb Compare June 10, 2024 06:35
@sbidoul sbidoul force-pushed the imp-invalid-req-reporting branch from c3434bb to beb4f29 Compare June 10, 2024 06:44
@pradyunsg pradyunsg merged commit 1a55574 into pypa:main Jun 10, 2024
28 checks passed
@sbidoul sbidoul deleted the imp-invalid-req-reporting branch June 10, 2024 19:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pfmoore pfmoore pfmoore approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.

Show the detailed error when facing invalid requirements
5 participants
@sbidoul @uranusjr @notatallshaw @pfmoore @pradyunsg