Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip debug error in Python 3.13 #12591

Closed
wants to merge 3 commits into from

Conversation

eggplants
Copy link

@eggplants eggplants commented Mar 23, 2024

Closes: #12590

Replaced Python>3.8:
importlib.resources.open_text(package, resource)

with:
files(package).joinpath(resource).open('r')

Ref:
https://docs.python.org/3.12/library/importlib.resources.html#importlib.resources.open_text

@eggplants eggplants force-pushed the fix-pip-debug-error branch 2 times, most recently from 90d569b to bb8cfe9 Compare March 23, 2024 13:10
@eggplants eggplants force-pushed the fix-pip-debug-error branch from bb8cfe9 to e6ad25e Compare March 23, 2024 13:36
@eggplants eggplants marked this pull request as ready for review March 23, 2024 13:51
@uranusjr
Copy link
Member

Let’s add 3.13 to the CI matrix.

@uranusjr
Copy link
Member

Closing for #12462 since that came first.

@uranusjr uranusjr closed this Mar 26, 2024
@uranusjr
Copy link
Member

Thanks for picking this up though! I wouldn’t notice the other PR if this doesn’t exist.

@eggplants eggplants deleted the fix-pip-debug-error branch March 27, 2024 02:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip debug causes AttributeError in Python 3.13
2 participants