Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the pip3.x entrypoint from the pip wheel #12536

Merged
merged 2 commits into from
Feb 24, 2024
Merged

Remove the pip3.x entrypoint from the pip wheel #12536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d0a49b
Remove the pip3.x entrypoint from the pip wheel
sbidoul Feb 23, 2024
83da7cb
Add news
sbidoul Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/12536.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Remove the incorrect pip3.x console entrypoint from the pip wheel. This console
script continue to be generated by pip when it installs itself.
6 changes: 5 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[project]
dynamic = ["version", "scripts"]
dynamic = ["version"]

name = "pip"
description = "The PyPA recommended tool for installing Python packages."
Expand Down Expand Up @@ -29,6 +29,10 @@ authors = [
# When changing this value, please change the other copy as well.
requires-python = ">=3.8"

[project.scripts]
pip = "pip._internal.cli.main:main"
pip3 = "pip._internal.cli.main:main"

[project.urls]
Homepage = "https://pip.pypa.io/"
Documentation = "https://pip.pypa.io"
Expand Down
12 changes: 1 addition & 11 deletions setup.py
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is setup.py still needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove it. I wanted to do it in another PR in case anyone has comments about that: #12537.

Original file line number Diff line number Diff line change
@@ -1,13 +1,3 @@
import sys

from setuptools import setup

setup(
entry_points={
"console_scripts": [
"pip=pip._internal.cli.main:main",
f"pip{sys.version_info[0]}=pip._internal.cli.main:main",
"pip{}.{}=pip._internal.cli.main:main".format(*sys.version_info[:2]),
],
},
)
setup()
Loading