Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct issue number for NEWS entry added by #12197 #12335

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

edmorley
Copy link
Contributor

The NEWS entry added in PR #12197 referenced issue #12191, however, the issue it actually fixed was #11847.

@uranusjr
Copy link
Member

cc @cosmicexplorer

@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 11, 2023
The NEWS entry added in PR pypa#12197 referenced issue pypa#12191,
however, the issue it actually fixed was pypa#11847.
@edmorley
Copy link
Contributor Author

I've rebased on main to get rid of the "this branch is out of date" warning.

Please could someone merge it, so it makes tomorrow's 23.3 release? :-)

@sbidoul sbidoul merged commit 3060865 into pypa:main Oct 14, 2023
12 checks passed
@edmorley edmorley deleted the patch-1 branch October 14, 2023 15:14
@pradyunsg
Copy link
Member

Thanks @edmorley for doing this! ^>^

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants