Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolution to respect --python-version when checking Requires-Python #12218

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Fix resolution to respect --python-version when checking Requires-Python #12218

merged 4 commits into from
Jul 9, 2024

Conversation

thejcannon
Copy link
Contributor

Fixes #12216

thejcannon
thejcannon commented Aug 8, 2023
View reviewed changes
tests/conftest.py
Comment on lines +372 to +375
assert len(wheel_candidates) == 1, (
f"Missing wheels in {common_wheels}, expected 1 got '{wheel_candidates}'."
" Are you running the tests via nox? See https://pip.pypa.io/en/latest/development/getting-started/#running-tests"
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by improvement, because my dumb self was trying to run pytest and didn't read the docs 😅

tests/functional/test_new_resolver.py
"0.1.0",
requires_python="<3",
)
result = script.pip(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently fails due to #12215, once #12217 is in, I'll merge main back into this branch.

@pradyunsg pradyunsg marked this pull request as draft August 9, 2023 02:50
@pradyunsg
Copy link
Member

Marking this as a draft until you're able to get CI happy. :)

Feel welcome to ask questions, if you have any!

@thejcannon
Copy link
Contributor Author

Yeah, that's just my comment above regarding failure (another CLI error regarding these flags)

I have another issue/fix that this currently bumps into.

Wanna go take a look at those? 🤓

@cclauss
Copy link
Contributor

cclauss commented Sep 1, 2023 •
edited
Loading

CI now seems happy on other PRs... https://github.com/pypa/pip/actions

@thejcannon
Copy link
Contributor Author

thejcannon commented Sep 1, 2023 •
edited
Loading

Yeah, this PR fail CI until the dependent PR is merged. I called it out above: #12218 (comment)

I don't think anyone has looked at that PR yet though...

@uranusjr
Copy link
Member

uranusjr commented Sep 6, 2023 •
edited
Loading

I’ve merged the depending PR to main and merged main into this one.

@thejcannon thejcannon marked this pull request as ready for review September 6, 2023 15:34
@thejcannon
Copy link
Contributor Author

Ok PR is ready to review!

@ichard26 ichard26 added this to the 24.2 milestone Jun 1, 2024
@pradyunsg pradyunsg merged commit 6b54c19 into pypa:main Jul 9, 2024
26 checks passed
@ichard26
Copy link
Member

Thanks @thejcannon! Sorry about the delay, but better than never :)

@thejcannon thejcannon deleted the jcannon/issue12216 branch July 10, 2024 03:33
@thejcannon
Copy link
Contributor Author

To be honest I forgot about it too 😂

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.

Requires-Python seems to ignore --python-version
5 participants
@thejcannon @pradyunsg @cclauss @uranusjr @ichard26