Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -C as a short version of --config-settings #11786

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Feb 8, 2023

Signed-off-by: Filipe Laíns [email protected]

@rgommers
Copy link

This is quite useful, thanks @FFY00. I know @henryiii was planning to do this exact same thing as well. This is a UX improvement, and also aligns pip with pypa/build, so +1 from me.

@henryiii
Copy link
Contributor

Just to follow up: Pip calls this --config-settings, while build calls it --config-setting and -C, so this would allow tutorials and such to use -C to work across both build and pip. Also, setting a config setting contains an equal sign, so this transforms --config-settings=build-dir=build into -Cbuild-dir=build, which is much nicer than having dual equals signs, I think. Finally, for PEP 517 backends, this is the core mechanic for communicating to the backend, and may easily be done multiple times in a single call, so having a short flag for it is warranted, I think.

@FFY00
Copy link
Member Author

FFY00 commented Feb 27, 2023

@pradyunsg could you have a look? This is a very small, but super useful, change. Thanks!

@pradyunsg pradyunsg merged commit 30fd549 into pypa:main Feb 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants