Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #11507

Closed
wants to merge 1 commit into from

Conversation

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from bccfc6f to 2274a72 Compare November 7, 2022 19:37
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 2274a72 to f9c4f2c Compare December 5, 2022 20:20
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from f9c4f2c to 8c07cd7 Compare January 2, 2023 20:49
@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Jan 30, 2023
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 8c07cd7 to 2cfcc06 Compare February 6, 2023 22:27
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 6, 2023
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 2cfcc06 to a3a521c Compare March 6, 2023 21:58
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from a3a521c to 26cc106 Compare April 3, 2023 23:10
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 26cc106 to a73295c Compare May 1, 2023 22:13
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from a73295c to 2de21c0 Compare June 5, 2023 21:52
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 2de21c0 to 7eb0359 Compare July 3, 2023 22:50
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 7eb0359 to ff11f90 Compare August 7, 2023 23:30
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from ff11f90 to 3cefbdd Compare September 4, 2023 23:48
@cclauss
Copy link
Contributor

cclauss commented Sep 6, 2023

pre-commit.ci run

@cclauss
Copy link
Contributor

cclauss commented Sep 6, 2023

@uranusjr Can you please make a pre-commit.ci run comment so that pre-commit.ci rebases this PR?

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 3cefbdd to 5bef7e7 Compare October 3, 2023 00:39
@uranusjr
Copy link
Member

uranusjr commented Oct 3, 2023

pre-commit.ci run

@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 3, 2023
@cclauss
Copy link
Contributor

cclauss commented Oct 3, 2023

@sbidoul
Copy link
Member

sbidoul commented Oct 3, 2023

pre-commit.ci run

@cclauss
Copy link
Contributor

cclauss commented Oct 4, 2023

@uranusjr I find these remaining mypy superconfusing to fix. I will be interested to see how you solve them.

There is a far amount of discussion that mypy is tricky to run correctly in pre-commit.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from d7b76f3 to 3236778 Compare November 6, 2023 18:24
@cclauss
Copy link
Contributor

cclauss commented Nov 7, 2023

mypy.....................................................................Failed
- hook id: mypy
- exit code: 2

tools/release/__init__.py: error: Source file found twice under different
module names: "release" and "tools.release"
tools/release/__init__.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
tools/release/__init__.py: note: Common resolutions include: a) adding `__init__.py` somewhere, b) using `--explicit-package-bases` or adjusting MYPYPATH
Found 1 error in 1 file (errors prevented further checking)

@notatallshaw
Copy link
Member

mypy.....................................................................Failed
- hook id: mypy
- exit code: 2

tools/release/__init__.py: error: Source file found twice under different
module names: "release" and "tools.release"
tools/release/__init__.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
tools/release/__init__.py: note: Common resolutions include: a) adding `__init__.py` somewhere, b) using `--explicit-package-bases` or adjusting MYPYPATH
Found 1 error in 1 file (errors prevented further checking)

I fixed that in this PR: #12389

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 3236778 to 1fc92f8 Compare December 4, 2023 18:23
@cclauss
Copy link
Contributor

cclauss commented Dec 4, 2023

@uranusjr Can't we just delete the comments from these two lines if the new mypy does not need them?

mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

src/pip/_internal/req/req_uninstall.py:176: error: Unused "type: ignore"
comment  [unused-ignore]
        _normcased_files = set(map(os.path.normcase, files))  # type: igno...
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tests/unit/test_vcs.py:462: error: Unused "type: ignore" comment 
[unused-ignore]
                vcs_cls.run_command([])  # type: ignore[arg-type]
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 2 errors in 2 files (checked 294 source files)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0)
- [github.com/psf/black: 23.7.0 → 23.12.1](psf/black@23.7.0...23.12.1)
- [github.com/astral-sh/ruff-pre-commit: v0.1.4 → v0.1.9](astral-sh/ruff-pre-commit@v0.1.4...v0.1.9)
- [github.com/pre-commit/mirrors-mypy: v1.6.1 → v1.8.0](pre-commit/mirrors-mypy@v1.6.1...v1.8.0)
hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix]

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.6.1
rev: v1.8.0
Copy link
Contributor

@cclauss cclauss Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the mypy change for now and allow the rest of this land

Suggested change
rev: v1.8.0
rev: v1.6.1

Or fix the failure by merging

@sbidoul
Copy link
Member

sbidoul commented Jan 15, 2024

Done in #12454

@sbidoul sbidoul closed this Jan 15, 2024
@sbidoul sbidoul deleted the pre-commit-ci-update-config branch January 15, 2024 11:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants