Refactor BaseDistribution.metadata property to make sure it has Requires-Dist and Provides-Extra
#11163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Jun 6, 2022
sbidoul
force-pushed
the
ref-metadata-sbi
branch
5 times, most recently
from
32311d2
to
9c119bc
Compare
sbidoul
changed the title
metadata property has Requires-Dist and Provides-ExtraBaseDistribution.metadata property to make sure it has Requires-Dist and Provides-Extra
egg-info distributions may not have the Requires-Dist and Provides-Extra fields in their metadata. For consistency and to provide an unsurprising metadata property, we emulate it by reading requires.txt.
sbidoul
force-pushed
the
ref-metadata-sbi
branch
from
f51516a
to
a814290
Compare
uranusjr
approved these changes
Jun 22, 2022
|
Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
egg-infodistribution may not have theRequires-DistandProvides-Extrafields in their metadata. For consistency, and to provide an unsurprisingBaseDistribution.metadataproperty, we emulate it by readingrequires.txt.The logic was already present in the
importlib.metadata.Distributionadapter, so we reuse it by moving the corresponding methods up toBaseDistribution.I noticed this while working on #10771 where the installation report was missing requires_dist for older setup.py projects.