Replace cgi module with email.message
#11098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
May 8, 2022
q0w
reviewed
May 8, 2022
|
After digging into a number of possibilities, I ran across a solution in the PEP 594 discussions from 2019 which point out that you an just use email.message.Message objects as an alternative. I have a working implementation with that I'll push shortly. Edit: As someone else pointed out in Discord just now, that solution also got copied directly into the PEP's text. I must be going blind. |
fungi
changed the title
uranusjr
reviewed
May 8, 2022
As of Python 3.11.0b1, the cgi module is deprecated per PEP 594 (Removing dead batteries from the standard library), and raises DeprecationWarning when imported. The only places pip relies on this are pip._internal.index.collector._get_encoding_from_headers() and pip._internal.network.download.parse_content_disposition() calling parse_headers(), so replace that with the solution recommended in an old PEP 594 thread from 2019: https://discuss.python.org/t/1704/14 Fixes: #11099
Added. If it's not obvious, I spend most of my time with other code review platforms and have to look up GitHub's conventions every time I try to use it. Thanks for the tip! |
|
Thanks for this effort! What's needed to merge this? |
pradyunsg
changed the title
cgi module with email.message
|
or like this aio-libs/aiohttp#6708 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Python 3.11.0b1, the cgi module is deprecated per PEP 594
(Removing dead batteries from the standard library), and raises
DeprecationWarning when imported. The only places pip relies on this
are pip._internal.index.collector._get_encoding_from_headers() and
pip._internal.network.download.parse_content_disposition() calling
parse_headers(), so replace that with the solution recommended in an
old PEP 594 thread from 2019: https://discuss.python.org/t/1704/14
Fixes: #11099