Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling mistakes and typos #10911

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Fix spelling mistakes and typos #10911

merged 2 commits into from
Feb 18, 2022
+2 −2

Conversation

yhay81
Copy link
Contributor

@yhay81 yhay81 commented Feb 17, 2022

I think this is trivial fix and fragment is not necessary.

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Feb 17, 2022
@pfmoore
Copy link
Member

pfmoore commented Feb 17, 2022

The files in _vendor are copied in from other projects, and we have a policy of not changing vendored code. Could you remove those from this PR, please?

DiddiLeija
DiddiLeija approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current CI failure on docs is unrelated to this PR, so it can go ahead :)

@q0w
Copy link
Contributor

q0w commented Feb 17, 2022 •
edited
Loading

The current CI failure on docs is unrelated to this PR, so it can go ahead :)

I've fixed it in 849402b (#10906). Could you review it?

@pradyunsg
Copy link
Member

Merging despite CI failures because this is literally a typo fix.

@pradyunsg pradyunsg merged commit 6e48ff7 into pypa:main Feb 18, 2022
@pradyunsg
Copy link
Member

I've fixed it in 849402b

I've cherry-picked that, rephrased the commit message and merged that in via #10912.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DiddiLeija DiddiLeija DiddiLeija approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yhay81 @pfmoore @q0w @pradyunsg @DiddiLeija